commit a5942c177b7bcc1357e496b7d68668befcfc2bb9
author Stefano Garzarella <sgarzare@redhat.com> Wed Jul 26 09:48:07 2023 +0200
committer Stefan Hajnoczi <stefanha@redhat.com> Wed Jul 26 11:29:39 2023 -0400
tree 15752b05bda8f66da2526dd31d5f74838b9ae1e8
parent 9359c459889fce1804c4e1b2a2ff8f182b4a9ae8

block/blkio: do not use open flags in qemu_open()

qemu_open() in blkio_virtio_blk_common_open() is used to open the
character device (e.g. /dev/vhost-vdpa-0 or /dev/vfio/vfio) or in
the future eventually the unix socket.

In all these cases we cannot open the path in read-only mode,
when the `read-only` option of blockdev is on, because the exchange
of IOCTL commands for example will fail.

In order to open the device read-only, we have to use the `read-only`
property of the libblkio driver as we already do in blkio_file_open().

Fixes: cad2ccc395 ("block/blkio: use qemu_open() to support fd passing for virtio-blk")
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2225439
Reported-by: Qing Wang <qinwang@redhat.com>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20230726074807.14041-1-sgarzare@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>