commit a54a0c113b333aee49e484758fab7f1f1c593dd3
author John Snow <jsnow@redhat.com> Tue Mar 12 12:05:49 2019 -0400
committer John Snow <jsnow@redhat.com> Tue Mar 12 12:05:49 2019 -0400
tree 8cfdf06740076e8fa58f5c10e589681d529fc702
parent 3ae96d66840f72ef54902d012dbdf87ef4e9fe0c

block/dirty-bitmaps: prohibit readonly bitmaps for backups

drive and blockdev backup cannot use readonly bitmaps, because the
sync=incremental mechanism actually edits the bitmaps on success.

If you really want to do this operation, use a copied bitmap.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-id: 20190301191545.8728-5-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>

blockdev.c

diff --git a/blockdev.c b/blockdev.c
index 5021f81..dd841fc 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3535,7 +3535,7 @@
             bdrv_unref(target_bs);
             goto out;
         }
-        if (bdrv_dirty_bitmap_check(bmap, BDRV_BITMAP_ALLOW_RO, errp)) {
+        if (bdrv_dirty_bitmap_check(bmap, BDRV_BITMAP_DEFAULT, errp)) {
             goto out;
         }
     }
@@ -3645,7 +3645,7 @@
             error_setg(errp, "Bitmap '%s' could not be found", backup->bitmap);
             goto out;
         }
-        if (bdrv_dirty_bitmap_check(bmap, BDRV_BITMAP_ALLOW_RO, errp)) {
+        if (bdrv_dirty_bitmap_check(bmap, BDRV_BITMAP_DEFAULT, errp)) {
             goto out;
         }
     }