commit a0506b7c8fc72f7bca272647f359d76cc40a02c1
author Markus Armbruster <armbru@redhat.com> Mon Jan 09 20:03:21 2023 +0100
committer Markus Armbruster <armbru@redhat.com> Thu Jan 19 13:30:01 2023 +0100
tree 31e6f54e44940fa3f1300b53eeaa3450d88a3095
parent ec843b97f2c02b85115c7c5c8799ea4d02ddfba7

ui: Simplify control flow in qemu_mouse_set()

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230109190321.1056914-18-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

ui/input.c

diff --git a/ui/input.c b/ui/input.c
index 7048810..f2d1e7a 100644
--- a/ui/input.c
+++ b/ui/input.c
@@ -595,28 +595,26 @@
 bool qemu_mouse_set(int index, Error **errp)
 {
     QemuInputHandlerState *s;
-    int found = 0;
 
     QTAILQ_FOREACH(s, &handlers, node) {
-        if (s->id != index) {
-            continue;
+        if (s->id == index) {
+            break;
         }
-        if (!(s->handler->mask & (INPUT_EVENT_MASK_REL |
-                                  INPUT_EVENT_MASK_ABS))) {
-            error_setg(errp, "Input device '%s' is not a mouse",
-                       s->handler->name);
-            return false;
-        }
-        found = 1;
-        qemu_input_handler_activate(s);
-        break;
     }
 
-    if (!found) {
+    if (!s) {
         error_setg(errp, "Mouse at index '%d' not found", index);
         return false;
     }
 
+    if (!(s->handler->mask & (INPUT_EVENT_MASK_REL |
+                              INPUT_EVENT_MASK_ABS))) {
+        error_setg(errp, "Input device '%s' is not a mouse",
+                   s->handler->name);
+        return false;
+    }
+
+    qemu_input_handler_activate(s);
     qemu_input_check_mode_change();
     return true;
 }