commit 9d6f1b73f83a02fb28438fa9a487f5c7d245e4af
author Luiz Capitulino <lcapitulino@redhat.com> Wed Oct 03 18:40:01 2012 -0300
committer Michael Roth <mdroth@linux.vnet.ibm.com> Tue Oct 09 03:42:42 2012 -0500
tree 569570bc7265c91b63bc146bc121e9eb73171c9f
parent 6a3c8c14c8467c5db3539f1b6e43e03318e5e21b

qemu-ga: ga_open_pidfile(): add new line to pidfile

FHS requires that pid files should end with a new line. Also change to
snprintf() while there.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>

qemu-ga.c

diff --git a/qemu-ga.c b/qemu-ga.c
index daeaea5..9b59a52 100644
--- a/qemu-ga.c
+++ b/qemu-ga.c
@@ -255,7 +255,7 @@
         g_critical("Failed to truncate pid file");
         goto fail;
     }
-    sprintf(pidstr, "%d", getpid());
+    snprintf(pidstr, sizeof(pidstr), "%d\n", getpid());
     if (write(pidfd, pidstr, strlen(pidstr)) != strlen(pidstr)) {
         g_critical("Failed to write pid file");
         goto fail;