commit 9cd7dde0730ed823b545910c0d5a676142015e3b
author Alex Chen <alex.chen@huawei.com> Tue Nov 10 19:23:08 2020 +0000
committer Alex Bennée <alex.bennee@linaro.org> Mon Nov 16 11:07:37 2020 +0000
tree fa518ff4b8cebe978044e5d027c38a4154181656
parent dbb864ba4f7bc419a3ce473aa9436cc41b2e3dfd

plugins: Fix two resource leaks in setup_socket()

Either accept() fails or exits normally, we need to close the fd.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20201109082829.87496-3-alex.chen@huawei.com>
Message-Id: <20201110192316.26397-3-alex.bennee@linaro.org>

contrib/plugins/lockstep.c

diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index 319bd44..5aad508 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -268,11 +268,13 @@
     socket_fd = accept(fd, NULL, NULL);
     if (socket_fd < 0 && errno != EINTR) {
         perror("accept socket");
+        close(fd);
         return false;
     }
 
     qemu_plugin_outs("setup_socket::ready\n");
 
+    close(fd);
     return true;
 }