Google Git
Sign in
qemu / qemu / 947231ad3b479de82d8f5ec185e2d00f3c96edcd
commit947231ad3b479de82d8f5ec185e2d00f3c96edcd[log] [tgz]
authorKevin Wolf <kwolf@redhat.com>Tue Jul 11 14:04:08 2017 +0200
committerKevin Wolf <kwolf@redhat.com>Tue Jul 18 15:14:36 2017 +0200
treeaeb085f4cb7bbe0914ba7bd72aa50f83d0a77dd2
parentec18b0a93a0b8f6f9a72bf2461dc7a0930391bfa [diff]
ide: bdrv_attach_dev() for empty CD-ROM

If no drive=... option is passed (for an empty drive), we don't only
lack the BlockBackend normally created by parse_drive(), but we also
need to manually call blk_attach_dev().

IDE does not support hot unplug, but if it did, qdev would take care to
call the matching blk_detach_dev() on unplug.

This fixes at least the bug that such devices didn't show up in
query-block, and probably some more problems.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
1 file changed
tree: aeb085f4cb7bbe0914ba7bd72aa50f83d0a77dd2
  1. accel/
  2. audio/
  3. backends/
  4. block/
  5. bsd-user/
  6. chardev/
  7. contrib/
  8. crypto/
  9. default-configs/
  10. disas/
  11. docs/
  12. fpu/
  13. fsdev/
  14. gdb-xml/
  15. hw/
  16. include/
  17. io/
  18. libdecnumber/
  19. linux-headers/
  20. linux-user/
  21. migration/
  22. nbd/
  23. net/
  24. pc-bios/
  25. po/
  26. qapi/
  27. qga/
  28. qobject/
  29. qom/
  30. replay/
  31. roms/
  32. scripts/
  33. slirp/
  34. stubs/
  35. target/
  36. tcg/
  37. tests/
  38. trace/
  39. ui/
  40. util/
  41. dtc
  42. pixman
  43. .dir-locals.el
  44. .exrc
  45. .gdbinit
  46. .gitignore
  47. .gitmodules
  48. .mailmap
  49. .shippable.yml
  50. .travis.yml
  51. arch_init.c
  52. atomic_template.h
  53. balloon.c
  54. block.c
  55. blockdev-nbd.c
  56. blockdev.c
  57. blockjob.c
  58. bootdevice.c
  59. bt-host.c
  60. bt-vhci.c
  61. Changelog
  62. CODING_STYLE
  63. configure
  64. COPYING
  65. COPYING.LIB
  66. cpus-common.c
  67. cpus.c
  68. device-hotplug.c
  69. device_tree.c
  70. disas.c
  71. dma-helpers.c
  72. dump.c
  73. exec.c
  74. gdbstub.c
  75. HACKING
  76. hax-stub.c
  77. hmp-commands-info.hx
  78. hmp-commands.hx
  79. hmp.c
  80. hmp.h
  81. ioport.c
  82. iothread.c
  83. LICENSE
  84. MAINTAINERS
  85. Makefile
  86. Makefile.objs
  87. Makefile.target
  88. memory.c
  89. memory_ldst.inc.c
  90. memory_mapping.c
  91. module-common.c
  92. monitor.c
  93. numa.c
  94. os-posix.c
  95. os-win32.c
  96. qapi-schema.json
  97. qdev-monitor.c
  98. qdict-test-data.txt
  99. qemu-bridge-helper.c
  100. qemu-doc.texi
  101. qemu-ga.texi
  102. qemu-img-cmds.hx
  103. qemu-img.c
  104. qemu-img.texi
  105. qemu-io-cmds.c
  106. qemu-io.c
  107. qemu-nbd.c
  108. qemu-nbd.texi
  109. qemu-option-trace.texi
  110. qemu-options-wrapper.h
  111. qemu-options.h
  112. qemu-options.hx
  113. qemu-seccomp.c
  114. qemu-tech.texi
  115. qemu.nsi
  116. qemu.sasl
  117. qmp.c
  118. qtest.c
  119. README
  120. replication.c
  121. replication.h
  122. rules.mak
  123. softmmu_template.h
  124. thunk.c
  125. tpm.c
  126. trace-events
  127. user-exec-stub.c
  128. user-exec.c
  129. VERSION
  130. version.rc
  131. vl.c