commit 8f419c5b43b988df4ef11315aeb8524e50c99687
author Alex Williamson <alex.williamson@redhat.com> Thu Apr 06 16:03:26 2017 -0600
committer Alex Williamson <alex.williamson@redhat.com> Thu Apr 06 16:03:26 2017 -0600
tree 012ea99abecf32424341c39e7553274c5ddb8835
parent 54d689988c847271d87b3eb113712147129fb811

vfio/pci-quirks: Exclude non-ioport BAR from NVIDIA quirk

The NVIDIA BAR5 quirk is targeting an ioport BAR.  Some older devices
have a BAR5 which is not ioport and can induce a segfault here.  Test
the BAR type to skip these devices.

Link: https://bugs.launchpad.net/qemu/+bug/1678466
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

hw/vfio/pci-quirks.c

diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
index e9b493b..349085e 100644
--- a/hw/vfio/pci-quirks.c
+++ b/hw/vfio/pci-quirks.c
@@ -660,7 +660,7 @@
     VFIOConfigWindowQuirk *window;
 
     if (!vfio_pci_is(vdev, PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID) ||
-        !vdev->vga || nr != 5) {
+        !vdev->vga || nr != 5 || !vdev->bars[5].ioport) {
         return;
     }