commit 8cf08065b1b19cea1958a43187755cec6546a5d0
author Bernhard Beschow <shentey@gmail.com> Fri Jun 30 09:37:05 2023 +0200
committer Michael S. Tsirkin <mst@redhat.com> Mon Jul 10 16:29:17 2023 -0400
tree 3652b6007eb9f1e52c050ddf504bac6485d02c22
parent 00f52e77d742c788ade7d713a7bf558481a89eec

hw/pci-host/q35: Fix double, contradicting .endianness assignment

Fixes the following clangd warning (-Winitializer-overrides):

  q35.c:297:19: Initializer overrides prior initialization of this subobject
  q35.c:292:19: previous initialization is here

Settle on little endian which is consistent with using pci_host_conf_le_ops.

Fixes: bafc90bdc594 ("q35: implement TSEG")
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230630073720.21297-3-shentey@gmail.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

hw/pci-host/q35.c

diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index fd18920..84137b9 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -285,7 +285,6 @@
 static const MemoryRegionOps blackhole_ops = {
     .read = blackhole_read,
     .write = blackhole_write,
-    .endianness = DEVICE_NATIVE_ENDIAN,
     .valid.min_access_size = 1,
     .valid.max_access_size = 4,
     .impl.min_access_size = 4,