commit 8ccf458af599673f622d14c8af84f063f69bba2d
author Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Thu Oct 17 17:21:22 2019 +0300
committer Kevin Wolf <kwolf@redhat.com> Fri Oct 25 15:15:01 2019 +0200
tree 01945b195c1356d4bc824c545b878341a5fce0e9
parent 46741111baab169482916d120d8949676ad16a77

block/backup: drop dead code from backup_job_create

After commit 00e30f05de1d195, there is no more "goto error" points
after job creation, so after "error:" @job is always NULL and we don't
need roll-back job creation.

Reported-by: Coverity (CID 1406402)
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Acked-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>

block/backup.c

diff --git a/block/backup.c b/block/backup.c
index dddcf77..cf62b1a 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -474,10 +474,7 @@
     if (sync_bitmap) {
         bdrv_reclaim_dirty_bitmap(sync_bitmap, NULL);
     }
-    if (job) {
-        backup_clean(&job->common.job);
-        job_early_fail(&job->common.job);
-    } else if (backup_top) {
+    if (backup_top) {
         bdrv_backup_top_drop(backup_top);
     }