commit 8574c9f1ad905e473593230308a0b2a68c46ebe3
author Markus Armbruster <armbru@redhat.com> Wed Dec 04 10:36:17 2019 +0100
committer Markus Armbruster <armbru@redhat.com> Wed Dec 18 08:36:15 2019 +0100
tree a738cb98df766882d975826b31a9a012d630f850
parent 292743d976324004d0c4f6f08e6d0589679d40ea

memory-device: Fix memory pre-plug error API violations

memory_device_get_free_addr() dereferences @errp when
memory_device_check_addable() fails.  That's wrong; see the big
comment in error.h.  Introduced in commit 1b6d6af21b "pc-dimm: factor
out capacity and slot checks into MemoryDevice".

No caller actually passes null.

Fix anyway: splice in a local Error *err, and error_propagate().

Cc: David Hildenbrand <david@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20191204093625.14836-11-armbru@redhat.com>

hw/mem/memory-device.c

diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
index aef148c..4bc9cf0 100644
--- a/hw/mem/memory-device.c
+++ b/hw/mem/memory-device.c
@@ -99,6 +99,7 @@
                                             uint64_t align, uint64_t size,
                                             Error **errp)
 {
+    Error *err = NULL;
     GSList *list = NULL, *item;
     Range as, new = range_empty;
 
@@ -123,8 +124,9 @@
         return 0;
     }
 
-    memory_device_check_addable(ms, size, errp);
-    if (*errp) {
+    memory_device_check_addable(ms, size, &err);
+    if (err) {
+        error_propagate(errp, err);
         return 0;
     }