commit 8379e46d1fd681b8aa4714382e2cdab05e5d0575
author Pavel Borzenkov <pavel.borzenkov@gmail.com> Tue Oct 18 21:19:03 2011 +0400
committer Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> Wed Oct 26 13:36:35 2011 +0100
tree e87e4c4c276f794838a7c219ffad6dd8ba798557
parent c18a1c88059bd546a198d95a10e9e17b11d062d1

vmdk: vmdk_read_cid returns garbage if p_name is NULL

Spotted by Clang Analyzer

Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

block/vmdk.c

diff --git a/block/vmdk.c b/block/vmdk.c
index 3969131..a75dcc2 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -207,7 +207,7 @@
 static uint32_t vmdk_read_cid(BlockDriverState *bs, int parent)
 {
     char desc[DESC_SIZE];
-    uint32_t cid;
+    uint32_t cid = 0xffffffff;
     const char *p_name, *cid_str;
     size_t cid_str_size;
     BDRVVmdkState *s = bs->opaque;