)]}'
{
  "commit": "82707dd4f07613eed8d639956a43bddffca5cd5c",
  "tree": "31a8542cc847e040a17a60eb7fa39bcccf94bfb3",
  "parents": [
    "8ed7c0b6488a7f20318d6ba414f1cbcd0ed92afe"
  ],
  "author": {
    "name": "Peter Maydell",
    "email": "peter.maydell@linaro.org",
    "time": "Thu May 01 10:31:26 2025 +0100"
  },
  "committer": {
    "name": "Peter Maydell",
    "email": "peter.maydell@linaro.org",
    "time": "Tue May 06 15:02:34 2025 +0100"
  },
  "message": "docs: Don\u0027t define duplicate label in qemu-block-drivers.rst.inc\n\nSphinx requires that labels within documents are unique across the\nwhole manual.  This is because the \"create a hyperlink\" directive\nspecifies only the name of the label, not a filename+label.  Some\nSphinx versions will warn about duplicate labels, but even if there\nis no warning there is still an ambiguity and no guarantee that the\nhyperlink will be created to the right target.\n\nFor QEMU this is awkward, because we have various .rst.inc fragments\nwhich we include into multiple .rst files.  If you define a label in\nthe .rst.inc file then it will be a duplicate label.  We have mostly\nworked around this by not putting labels into those .rst.inc files,\nor by adding \"insert a label\" functionality into the hxtool extension\n(see commit 1eeb432a953b0 \"doc/sphinx/hxtool.py: add optional label\nargument to SRST directive\").\n\nUnfortunately in commit 7f6314427e78 (\"docs/devel: add a codebase\nsection\") we accidentally added a duplicate label, because not all\nSphinx versions warn about the mistake.\n\nIn this case the link was only from the developer docs codebase\nsummary, so as the simplest fix for the stable branch, we drop\nthe link entirely.\n\nCc: qemu-stable@nongnu.org\nFixes: 1eeb432a953b0 \"doc/sphinx/hxtool.py: add optional label argument to SRST directive\"\nReported-by: Dario Faggioli \u003cdfaggioli@suse.com\u003e\nSigned-off-by: Peter Maydell \u003cpeter.maydell@linaro.org\u003e\nAcked-by: Eric Blake \u003ceblake@redhat.com\u003e\nReviewed-by: Pierrick Bouvier \u003cpierrick.bouvier@linaro.org\u003e\nMessage-id: 20250501093126.716667-1-peter.maydell@linaro.org\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "40273e7d31e11196578484bb6253e11911cc980e",
      "old_mode": 33188,
      "old_path": "docs/devel/codebase.rst",
      "new_id": "2a3143787a6cea1c72f8e657f512e56904173b2e",
      "new_mode": 33188,
      "new_path": "docs/devel/codebase.rst"
    },
    {
      "type": "modify",
      "old_id": "cfe1acb78ae552000b5856d7bf3b8eaa9ce58e07",
      "old_mode": 33188,
      "old_path": "docs/system/qemu-block-drivers.rst.inc",
      "new_id": "384e95ba76504df3f3a8f9a320a783f9127d9e14",
      "new_mode": 33188,
      "new_path": "docs/system/qemu-block-drivers.rst.inc"
    }
  ]
}