commit 822f98d2a56c8dcc857bb6a4c4da6382787533a0
author Jan Kiszka <jan.kiszka@siemens.com> Tue Jan 31 13:45:30 2012 +0100
committer Anthony Liguori <aliguori@us.ibm.com> Wed Feb 01 14:45:02 2012 -0600
tree 7f3677d0c735028618301e5717fd843e6f22fcad
parent eaa2e027b73c9afca623d877c91150a94c83049d

sdl: Grab input on end of non-absolute mouse click

By grabbing the input already on button down, we leave the button in
that state for the host GUI. Thus it takes another click after releasing
the input again to synchronize the mouse button state.

Avoid this by grabbing on button up.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

ui/sdl.c

diff --git a/ui/sdl.c b/ui/sdl.c
index 0d3a889..73e5839 100644
--- a/ui/sdl.c
+++ b/ui/sdl.c
@@ -802,8 +802,7 @@
 
     bev = &ev->button;
     if (!gui_grab && !kbd_mouse_is_absolute()) {
-        if (ev->type == SDL_MOUSEBUTTONDOWN &&
-            (bev->button == SDL_BUTTON_LEFT)) {
+        if (ev->type == SDL_MOUSEBUTTONUP && bev->button == SDL_BUTTON_LEFT) {
             /* start grabbing all events */
             sdl_grab_start();
         }