commit 818e1636080768749dc826acd4825e71828ec7e6
author Rohit Kumar <rohit.kumar3@nutanix.com> Tue Feb 15 23:15:08 2022 -0800
committer Thomas Huth <thuth@redhat.com> Mon Mar 07 19:00:05 2022 +0100
tree c3c4d04e97b0d03fcbf04911367f00628ca8e426
parent 63021223ff2d3db51cb784ab645275543e9d136a

Check and report for incomplete 'global' option format

Qemu might crash when provided incomplete '-global' option.
For example:
     qemu-system-x86_64 -global driver=isa-fdc
     qemu-system-x86_64: ../../devel/qemu/qapi/string-input-visitor.c:394:
     string_input_visitor_new: Assertion `str' failed.
     Aborted (core dumped)

Fixes: 3751d7c43f795b ("vl: allow full-blown QemuOpts syntax for -global")
Signed-off-by: Rohit Kumar <rohit.kumar3@nutanix.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/604
Message-Id: <20220216071508.412974-1-rohit.kumar3@nutanix.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>

softmmu/qdev-monitor.c

diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c
index fe6cf26..12fe60c 100644
--- a/softmmu/qdev-monitor.c
+++ b/softmmu/qdev-monitor.c
@@ -1038,6 +1038,13 @@
     if (!opts) {
         return -1;
     }
+    if (!qemu_opt_get(opts, "driver")
+        || !qemu_opt_get(opts, "property")
+        || !qemu_opt_get(opts, "value")) {
+        error_report("options 'driver', 'property', and 'value'"
+                     " are required");
+        return -1;
+    }
 
     return 0;
 }