commit 76abe4071d111a9ca6dcc9b9689a831c39ffa718
author Paolo Bonzini <pbonzini@redhat.com> Mon Feb 17 14:44:06 2014 +0100
committer Kevin Wolf <kwolf@redhat.com> Fri Feb 21 21:02:24 2014 +0100
tree fc844ff36395e5b133a7d1b7f60fe7a56bb85d61
parent 89ac8480a8c7f73dd943dcb1313d6bd984f9a870

block: do not abuse EMEDIUMTYPE

Returning "Wrong medium type" for an image that does not have a valid
header is a bit weird.  Improve the error by mentioning what format
was trying to open it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>

block/qcow.c

diff --git a/block/qcow.c b/block/qcow.c
index ef8920b..1e128be 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -113,7 +113,8 @@
     be64_to_cpus(&header.l1_table_offset);
 
     if (header.magic != QCOW_MAGIC) {
-        ret = -EMEDIUMTYPE;
+        error_setg(errp, "Image not in qcow format");
+        ret = -EINVAL;
         goto fail;
     }
     if (header.version != QCOW_VERSION) {