Google Git
Sign in
qemu / qemu / 74e43b04b0260da09d14bc56a5d629d4753b8b27
commit74e43b04b0260da09d14bc56a5d629d4753b8b27[log] [tgz]
authorPeter Maydell <peter.maydell@linaro.org>Mon Aug 09 16:54:24 2021 +0100
committerLaurent Vivier <laurent@vivier.eu>Thu Sep 16 17:04:21 2021 +0200
treeef6cf66ed2a63f75cd544d397f36e5ca8f525e71
parentd0a7920eb4fc44dd4485167edf7db7fac1de6977 [diff]
linux-user: Check lock_user result for ip_mreq_source sockopts

In do_setsockopt(), the code path for the options which take a struct
ip_mreq_source (IP_BLOCK_SOURCE, IP_UNBLOCK_SOURCE,
IP_ADD_SOURCE_MEMBERSHIP and IP_DROP_SOURCE_MEMBERSHIP) fails to
check the return value from lock_user().  Handle this in the usual
way by returning -TARGET_EFAULT.

(In practice this was probably harmless because we'd pass a NULL
pointer to setsockopt() and the kernel would then return EFAULT.)

Fixes: Coverity CID 1459987
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20210809155424.30968-1-peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
1 file changed
tree: ef6cf66ed2a63f75cd544d397f36e5ca8f525e71
  1. .github/
  2. .gitlab/
  3. .gitlab-ci.d/
  4. accel/
  5. audio/
  6. authz/
  7. backends/
  8. block/
  9. bsd-user/
  10. chardev/
  11. configs/
  12. contrib/
  13. crypto/
  14. disas/
  15. docs/
  16. dump/
  17. ebpf/
  18. fpu/
  19. fsdev/
  20. gdb-xml/
  21. hw/
  22. include/
  23. io/
  24. libdecnumber/
  25. linux-headers/
  26. linux-user/
  27. migration/
  28. monitor/
  29. nbd/
  30. net/
  31. pc-bios/
  32. plugins/
  33. po/
  34. python/
  35. qapi/
  36. qga/
  37. qobject/
  38. qom/
  39. replay/
  40. roms/
  41. scripts/
  42. scsi/
  43. semihosting/
  44. softmmu/
  45. storage-daemon/
  46. stubs/
  47. subprojects/
  48. target/
  49. tcg/
  50. tests/
  51. tools/
  52. trace/
  53. ui/
  54. util/
  55. capstone
  56. dtc
  57. meson
  58. slirp
  59. .cirrus.yml
  60. .dir-locals.el
  61. .editorconfig
  62. .exrc
  63. .gdbinit
  64. .gitattributes
  65. .gitignore
  66. .gitlab-ci.yml
  67. .gitmodules
  68. .gitpublish
  69. .mailmap
  70. .patchew.yml
  71. .readthedocs.yml
  72. .travis.yml
  73. block.c
  74. blockdev-nbd.c
  75. blockdev.c
  76. blockjob.c
  77. configure
  78. COPYING
  79. COPYING.LIB
  80. cpu.c
  81. cpus-common.c
  82. disas.c
  83. gdbstub.c
  84. gitdm.config
  85. hmp-commands-info.hx
  86. hmp-commands.hx
  87. iothread.c
  88. job-qmp.c
  89. job.c
  90. Kconfig
  91. Kconfig.host
  92. LICENSE
  93. MAINTAINERS
  94. Makefile
  95. memory_ldst.c.inc
  96. meson.build
  97. meson_options.txt
  98. module-common.c
  99. os-posix.c
  100. os-win32.c
  101. page-vary-common.c
  102. page-vary.c
  103. qemu-bridge-helper.c
  104. qemu-edid.c
  105. qemu-img-cmds.hx
  106. qemu-img.c
  107. qemu-io-cmds.c
  108. qemu-io.c
  109. qemu-keymap.c
  110. qemu-nbd.c
  111. qemu-options.hx
  112. qemu.nsi
  113. qemu.sasl
  114. README.rst
  115. replication.c
  116. thunk.c
  117. trace-events
  118. VERSION
  119. version.rc