Google Git
Sign in
qemu / qemu / 70b6d525dfb51d5e523d568d1139fc051bc223c5
commit70b6d525dfb51d5e523d568d1139fc051bc223c5[log] [tgz]
authorIgor Mammedov <imammedo@redhat.com>Thu Apr 30 11:46:06 2020 -0400
committerEduardo Habkost <ehabkost@redhat.com>Tue May 12 12:48:57 2020 -0400
treed074d23bb88164f58180f4c5db6a09c78e2dea4a
parentde2f658b6bb422ec0e0fa94a49e476018602eeea [diff]
hostmem: don't use mbind() if host-nodes is empty

Since 5.0 QEMU uses hostmem backend for allocating main guest RAM.
The backend however calls mbind() which is typically NOP
in case of default policy/absent host-nodes bitmap.
However when runing in container with black-listed mbind()
syscall, QEMU fails to start with error
 "cannot bind memory to host NUMA nodes: Operation not permitted"
even when user hasn't provided host-nodes to pin to explictly
(which is the case with -m option)

To fix issue, call mbind() only in case when user has provided
host-nodes explicitly (i.e. host_nodes bitmap is not empty).
That should allow to run QEMU in containers with black-listed
mbind() without memory pinning. If QEMU provided memory-pinning
is required user still has to white-list mbind() in container
configuration.

Reported-by: Manuel Hohmann <mhohmann@physnet.uni-hamburg.de>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20200430154606.6421-1-imammedo@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
1 file changed
tree: d074d23bb88164f58180f4c5db6a09c78e2dea4a
  1. .github/
  2. .gitlab-ci.d/
  3. accel/
  4. audio/
  5. authz/
  6. backends/
  7. block/
  8. bsd-user/
  9. chardev/
  10. contrib/
  11. crypto/
  12. default-configs/
  13. disas/
  14. docs/
  15. dump/
  16. fpu/
  17. fsdev/
  18. gdb-xml/
  19. hw/
  20. include/
  21. io/
  22. libdecnumber/
  23. linux-headers/
  24. linux-user/
  25. migration/
  26. monitor/
  27. nbd/
  28. net/
  29. pc-bios/
  30. plugins/
  31. po/
  32. python/
  33. qapi/
  34. qga/
  35. qobject/
  36. qom/
  37. replay/
  38. roms/
  39. scripts/
  40. scsi/
  41. softmmu/
  42. storage-daemon/
  43. stubs/
  44. target/
  45. tcg/
  46. tests/
  47. tools/
  48. trace/
  49. ui/
  50. util/
  51. capstone
  52. dtc
  53. slirp
  54. .cirrus.yml
  55. .dir-locals.el
  56. .editorconfig
  57. .exrc
  58. .gdbinit
  59. .gitignore
  60. .gitlab-ci-edk2.yml
  61. .gitlab-ci-opensbi.yml
  62. .gitlab-ci.yml
  63. .gitmodules
  64. .gitpublish
  65. .mailmap
  66. .patchew.yml
  67. .readthedocs.yml
  68. .shippable.yml
  69. .travis.yml
  70. arch_init.c
  71. balloon.c
  72. block.c
  73. blockdev-nbd.c
  74. blockdev.c
  75. blockjob.c
  76. bootdevice.c
  77. Changelog
  78. CODING_STYLE.rst
  79. configure
  80. COPYING
  81. COPYING.LIB
  82. cpus-common.c
  83. cpus.c
  84. device_tree.c
  85. disas.c
  86. dma-helpers.c
  87. exec-vary.c
  88. exec.c
  89. gdbstub.c
  90. gitdm.config
  91. hmp-commands-info.hx
  92. hmp-commands.hx
  93. ioport.c
  94. iothread.c
  95. job-qmp.c
  96. job.c
  97. Kconfig.host
  98. LICENSE
  99. MAINTAINERS
  100. Makefile
  101. Makefile.objs
  102. Makefile.target
  103. memory.c
  104. memory_ldst.inc.c
  105. memory_mapping.c
  106. module-common.c
  107. os-posix.c
  108. os-win32.c
  109. qdev-monitor.c
  110. qemu-bridge-helper.c
  111. qemu-edid.c
  112. qemu-img-cmds.hx
  113. qemu-img.c
  114. qemu-io-cmds.c
  115. qemu-io.c
  116. qemu-keymap.c
  117. qemu-nbd.c
  118. qemu-options-wrapper.h
  119. qemu-options.h
  120. qemu-options.hx
  121. qemu-seccomp.c
  122. qemu-storage-daemon.c
  123. qemu.nsi
  124. qemu.sasl
  125. qtest.c
  126. README.rst
  127. replication.c
  128. replication.h
  129. rules.mak
  130. thunk.c
  131. tpm.c
  132. trace-events
  133. VERSION
  134. version.rc