Google Git
Sign in
qemu / qemu / 6970c5ff13a47df7ce41b901a4459c587a03d16b
commit6970c5ff13a47df7ce41b901a4459c587a03d16b[log] [tgz]
authorIgor Mammedov <imammedo@redhat.com>Tue Oct 10 14:34:39 2017 +0200
committerPaolo Bonzini <pbonzini@redhat.com>Thu Oct 12 12:10:38 2017 +0200
tree947a2d6b7402339778603fff67c534148c21f480
parentb021d1c04452276f4926eed2d104ccbd1037a6e1 [diff]
pc: make sure that plugged CPUs are of the same type

heterogeneous cpus are not supported and hotplugging different
cpu model crashes QEMU:

  qemu-system-x86_64 -cpu qemu64 -smp 1,maxcpus=2
  (qemu) device_add host-x86_64-cpu,socket-id=1,core-id=0,thread-id=0,id=foo
  (qemu) info cpus
  error: failed to get MSR 0x38d
  qemu-system-x86_64: target/i386/kvm.c:2121: kvm_get_msrs: Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed.
  Aborted (core dumped)

Gracefully fail hotplug process in case of user mistake.

Reported-by: Greg Kurz <groug@kaod.org>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <1507638879-200718-1-git-send-email-imammedo@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
1 file changed
tree: 947a2d6b7402339778603fff67c534148c21f480
  1. accel/
  2. audio/
  3. backends/
  4. block/
  5. bsd-user/
  6. chardev/
  7. contrib/
  8. crypto/
  9. default-configs/
  10. disas/
  11. docs/
  12. fpu/
  13. fsdev/
  14. gdb-xml/
  15. hw/
  16. include/
  17. io/
  18. libdecnumber/
  19. linux-headers/
  20. linux-user/
  21. migration/
  22. nbd/
  23. net/
  24. pc-bios/
  25. po/
  26. qapi/
  27. qga/
  28. qobject/
  29. qom/
  30. replay/
  31. roms/
  32. scripts/
  33. scsi/
  34. slirp/
  35. stubs/
  36. target/
  37. tcg/
  38. tests/
  39. trace/
  40. ui/
  41. util/
  42. dtc
  43. .dir-locals.el
  44. .editorconfig
  45. .exrc
  46. .gdbinit
  47. .gitignore
  48. .gitmodules
  49. .mailmap
  50. .shippable.yml
  51. .travis.yml
  52. arch_init.c
  53. balloon.c
  54. block.c
  55. blockdev-nbd.c
  56. blockdev.c
  57. blockjob.c
  58. bootdevice.c
  59. bt-host.c
  60. bt-vhci.c
  61. Changelog
  62. CODING_STYLE
  63. configure
  64. COPYING
  65. COPYING.LIB
  66. COPYING.PYTHON
  67. cpus-common.c
  68. cpus.c
  69. device-hotplug.c
  70. device_tree.c
  71. disas.c
  72. dma-helpers.c
  73. dump.c
  74. exec.c
  75. gdbstub.c
  76. HACKING
  77. hmp-commands-info.hx
  78. hmp-commands.hx
  79. hmp.c
  80. hmp.h
  81. ioport.c
  82. iothread.c
  83. LICENSE
  84. MAINTAINERS
  85. Makefile
  86. Makefile.objs
  87. Makefile.target
  88. memory.c
  89. memory_ldst.inc.c
  90. memory_mapping.c
  91. module-common.c
  92. monitor.c
  93. numa.c
  94. os-posix.c
  95. os-win32.c
  96. qapi-schema.json
  97. qdev-monitor.c
  98. qdict-test-data.txt
  99. qemu-bridge-helper.c
  100. qemu-doc.texi
  101. qemu-ga.texi
  102. qemu-img-cmds.hx
  103. qemu-img.c
  104. qemu-img.texi
  105. qemu-io-cmds.c
  106. qemu-io.c
  107. qemu-nbd.c
  108. qemu-nbd.texi
  109. qemu-option-trace.texi
  110. qemu-options-wrapper.h
  111. qemu-options.h
  112. qemu-options.hx
  113. qemu-seccomp.c
  114. qemu-tech.texi
  115. qemu.nsi
  116. qemu.sasl
  117. qmp.c
  118. qtest.c
  119. README
  120. replication.c
  121. replication.h
  122. rules.mak
  123. thunk.c
  124. tpm.c
  125. trace-events
  126. VERSION
  127. version.rc
  128. vl.c