commit 61c1117f08f4ed6f7e5cfa59cc9e02cf19c8f92d
author Hans de Goede <hdegoede@redhat.com> Tue May 31 11:35:20 2011 +0200
committer Gerd Hoffmann <kraxel@redhat.com> Tue Jun 14 12:56:49 2011 +0200
tree 5d2e0b260fe150cedbc5cd1e761b39837eb6f7fc
parent f264cfbf4a010e1be879bf2e62d323443989d72f

usb-linux: Don't do perror when errno is not set

Note that "op" also is not set, so before this change these error paths
would feed NULL to perror.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

usb-linux.c

diff --git a/usb-linux.c b/usb-linux.c
index ed1d56a..feb4d36 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -376,7 +376,8 @@
     i = 0;
     dev_descr_len = dev->descr[0];
     if (dev_descr_len > dev->descr_len) {
-        goto fail;
+        fprintf(stderr, "husb: update iface failed. descr too short\n");
+        return 0;
     }
 
     i += dev_descr_len;
@@ -404,7 +405,7 @@
     if (i >= dev->descr_len) {
         fprintf(stderr,
                 "husb: update iface failed. no matching configuration\n");
-        goto fail;
+        return 0;
     }
     nb_interfaces = dev->descr[i + 4];