commit 5df5416e639cd75bd85d243af41387c2418fa580
author Dr. David Alan Gilbert <dgilbert@redhat.com> Wed Nov 18 11:48:41 2015 +0000
committer Juan Quintela <quintela@redhat.com> Thu Nov 19 11:49:53 2015 +0100
tree bb45896d8dc18840572f5f3456d3a4dedc6be594
parent 95a7788b2faa81ff95675f1e46a3272a612b35de

Unneeded NULL check

The check is unneccesary, we read the value at the start of the
thread, use it, and never change it.  The value is checked to be
non-NULL before thread creation.

Spotted by coverity, CID 1339211

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>

migration/migration.c

diff --git a/migration/migration.c b/migration/migration.c
index 265d13a..1a42aee 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1345,7 +1345,7 @@
             break;
         }
     }
-    if (rp && qemu_file_get_error(rp)) {
+    if (qemu_file_get_error(rp)) {
         trace_source_return_path_thread_bad_end();
         mark_source_rp_bad(ms);
     }