)]}'
{
  "commit": "5cb993ff131fca2abef3ce074a20258fd6fce557",
  "tree": "79d7a5e8cbb6409807433ca195bf5dc6608fbc28",
  "parents": [
    "b6903cbe3a2e3feb7204636209b5607e70fee998"
  ],
  "author": {
    "name": "Bernhard Beschow",
    "email": "shentey@gmail.com",
    "time": "Sat Mar 18 19:59:31 2023 +0100"
  },
  "committer": {
    "name": "Thomas Huth",
    "email": "thuth@redhat.com",
    "time": "Mon Mar 20 12:43:50 2023 +0100"
  },
  "message": "qemu/osdep: Switch position of \"extern\" and \"G_NORETURN\"\n\nFixes the Windows build under msys2 using GCC 12 which fails with the following\nerror:\n\n  [184/579] Compiling C++ object qga/vss-win32/qga-vss.dll.p/install.cpp.obj\n  FAILED: qga/vss-win32/qga-vss.dll.p/install.cpp.obj\n  \"c++\" \"-m64\" \"-mcx16\" \"-Iqga/vss-win32/qga-vss.dll.p\" \"-Iqga/vss-win32\" \"-I../src/qga/vss-win32\" \"-I.\" \"-Iqapi\" \"-Itrace\" \"-Iui\" \"-Iui/shader\" \"-IC:/msys64/mingw64/include/glib-2.0\" \"-IC:/msys64/mingw64/lib/glib-2.0/include\" \"-fdiagnostics-color\u003dauto\" \"-Wall\" \"-Winvalid-pch\" \"-Wnon-virtual-dtor\" \"-Werror\" \"-std\u003dgnu++11\" \"-g\" \"-iquote\" \".\" \"-iquote\" \"C:/msys64/home/shentey/Projects/qemu/src\" \"-iquote\" \"C:/msys64/home/shentey/Projects/qemu/src/include\" \"-iquote\" \"C:/msys64/home/shentey/Projects/qemu/src/tcg/i386\" \"-D__STDC_LIMIT_MACROS\" \"-D__STDC_CONSTANT_MACROS\" \"-D__STDC_FORMAT_MACROS\" \"-fno-pie\" \"-no-pie\" \"-D_GNU_SOURCE\" \"-D_FILE_OFFSET_BITS\u003d64\" \"-D_LARGEFILE_SOURCE\" \"-fno-strict-aliasing\" \"-fno-common\" \"-fwrapv\" \"-Wundef\" \"-Wwrite-strings\" \"-Wtype-limits\" \"-Wformat-security\" \"-Wformat-y2k\" \"-Winit-self\" \"-Wignored-qualifiers\" \"-Wempty-body\" \"-Wendif-labels\" \"-Wexpansion-to-defined\" \"-Wimplicit-fallthrough\u003d2\" \"-Wmissing-format-attribute\" \"-Wno-missing-include-dirs\" \"-Wno-shift-negative-value\" \"-Wno-psabi\" \"-fstack-protector-strong\" \"-Wno-unknown-pragmas\" \"-Wno-delete-non-virtual-dtor\" \"-Wno-non-virtual-dtor\" -MD -MQ qga/vss-win32/qga-vss.dll.p/install.cpp.obj -MF \"qga/vss-win32/qga-vss.dll.p/install.cpp.obj.d\" -o qga/vss-win32/qga-vss.dll.p/install.cpp.obj \"-c\" ../src/qga/vss-win32/install.cpp\n  In file included from C:/msys64/mingw64/lib/glib-2.0/include/glibconfig.h:9,\n              from C:/msys64/mingw64/include/glib-2.0/glib/gtypes.h:34,\n              from C:/msys64/mingw64/include/glib-2.0/glib/galloca.h:34,\n              from C:/msys64/mingw64/include/glib-2.0/glib.h:32,\n              from C:/msys64/home/shentey/Projects/qemu/src/include/glib-compat.h:32,\n              from C:/msys64/home/shentey/Projects/qemu/src/include/qemu/osdep.h:144,\n              from ../src/qga/vss-win32/install.cpp:13:\n  C:/msys64/mingw64/include/glib-2.0/glib/gmacros.h:1075:21: error: standard attributes in middle of decl-specifiers\n  1075 | # define G_NORETURN [[noreturn]]\n        |                     ^\n  C:/msys64/home/shentey/Projects/qemu/src/include/qemu/osdep.h:240:8: note: in expansion of macro \u0027G_NORETURN\u0027\n  240 | extern G_NORETURN\n        |        ^~~~~~~~~~\n  C:/msys64/mingw64/include/glib-2.0/glib/gmacros.h:1075:21: note: standard attributes must precede the decl-specifiers to apply to the declaration, or follow them to apply to the type\n  1075 | # define G_NORETURN [[noreturn]]\n        |                     ^\n  C:/msys64/home/shentey/Projects/qemu/src/include/qemu/osdep.h:240:8: note: in expansion of macro \u0027G_NORETURN\u0027\n  240 | extern G_NORETURN\n        |        ^~~~~~~~~~\n  C:/msys64/mingw64/include/glib-2.0/glib/gmacros.h:1075:21: error: attribute ignored [-Werror\u003dattributes]\n  1075 | # define G_NORETURN [[noreturn]]\n        |                     ^\n  C:/msys64/home/shentey/Projects/qemu/src/include/qemu/osdep.h:240:8: note: in expansion of macro \u0027G_NORETURN\u0027\n  240 | extern G_NORETURN\n        |        ^~~~~~~~~~\n  C:/msys64/mingw64/include/glib-2.0/glib/gmacros.h:1075:21: note: an attribute that appertains to a type-specifier is ignored\n  1075 | # define G_NORETURN [[noreturn]]\n        |                     ^\n  C:/msys64/home/shentey/Projects/qemu/src/include/qemu/osdep.h:240:8: note: in expansion of macro \u0027G_NORETURN\u0027\n  240 | extern G_NORETURN\n        |        ^~~~~~~~~~\n  cc1plus.exe: all warnings being treated as errors\n\nApparently it also fixes the compilation with Clang 15 (see\nhttps://gitlab.com/qemu-project/qemu/-/issues/1541 ).\n\nResolves: https://gitlab.com/qemu-project/qemu/-/issues/1541\nSigned-off-by: Bernhard Beschow \u003cshentey@gmail.com\u003e\nMessage-Id: \u003c20230318185931.181659-1-shentey@gmail.com\u003e\nReviewed-by: Peter Maydell \u003cpeter.maydell@linaro.org\u003e\nSigned-off-by: Thomas Huth \u003cthuth@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "f68b5d8708c82ba2cb535e11affdeb3f296a9ab4",
      "old_mode": 33188,
      "old_path": "include/qemu/osdep.h",
      "new_id": "9eff0be95bd5c90ed7ee70ee3b561361bc65943d",
      "new_mode": 33188,
      "new_path": "include/qemu/osdep.h"
    }
  ]
}