commit 5c17ca2505197c56d0097c66a4e5bda4d6f32fb6
author Markus Armbruster <armbru@redhat.com> Wed Oct 07 01:16:01 2009 +0200
committer Anthony Liguori <aliguori@us.ibm.com> Wed Oct 07 08:54:55 2009 -0500
tree 011adae1a2f9ce724c92629bd99b78507a7d97ec
parent dde8bbb44de41ea68f9bede0a6a778ce046b2bcf

Clean up test for qdev_init() failure

Some callers test for != 0, some for < 0.  Normalize to < 0.

Patchworks-ID: 35171
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

hw/ide/isa.c

diff --git a/hw/ide/isa.c b/hw/ide/isa.c
index 3205f40..9f0fdd6 100644
--- a/hw/ide/isa.c
+++ b/hw/ide/isa.c
@@ -85,7 +85,7 @@
     qdev_prop_set_uint32(&dev->qdev, "iobase",  iobase);
     qdev_prop_set_uint32(&dev->qdev, "iobase2", iobase2);
     qdev_prop_set_uint32(&dev->qdev, "irq",     isairq);
-    if (qdev_init(&dev->qdev) != 0)
+    if (qdev_init(&dev->qdev) < 0)
         return -1;
 
     s = DO_UPCAST(ISAIDEState, dev, dev);