Google Git
Sign in
qemu / qemu / 5b774fe5505dc7daad908f9f4b95e9e735c45c14
commit5b774fe5505dc7daad908f9f4b95e9e735c45c14[log] [tgz]
authorPaolo Bonzini <pbonzini@redhat.com>Wed Feb 20 15:33:27 2019 +0100
committerPaolo Bonzini <pbonzini@redhat.com>Thu Mar 07 16:50:04 2019 +0100
tree068be487b96ffe6dfb076f22a9a30120aaea5ab4
parent3a75ef6a0fe397b0d36930415be6b123750a6afe [diff]
chardev-socket: do not blindly reset handlers when switching GMainContext

If the socket is connecting or connected, tcp_chr_update_read_handler will
be called but it should not set the NetListener's callbacks again.
Otherwise, tcp_chr_accept is invoked while the socket is in connected
state and you get an assertion failure.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2 files changed
tree: 068be487b96ffe6dfb076f22a9a30120aaea5ab4
  1. accel/
  2. audio/
  3. authz/
  4. backends/
  5. block/
  6. bsd-user/
  7. chardev/
  8. contrib/
  9. crypto/
  10. default-configs/
  11. disas/
  12. docs/
  13. fpu/
  14. fsdev/
  15. gdb-xml/
  16. hw/
  17. include/
  18. io/
  19. libdecnumber/
  20. linux-headers/
  21. linux-user/
  22. migration/
  23. nbd/
  24. net/
  25. pc-bios/
  26. po/
  27. qapi/
  28. qga/
  29. qobject/
  30. qom/
  31. replay/
  32. roms/
  33. scripts/
  34. scsi/
  35. slirp/
  36. stubs/
  37. target/
  38. tcg/
  39. tests/
  40. trace/
  41. ui/
  42. util/
  43. capstone
  44. dtc
  45. .cirrus.yml
  46. .dir-locals.el
  47. .editorconfig
  48. .exrc
  49. .gdbinit
  50. .gitignore
  51. .gitlab-ci.yml
  52. .gitmodules
  53. .gitpublish
  54. .mailmap
  55. .shippable.yml
  56. .travis.yml
  57. arch_init.c
  58. balloon.c
  59. block.c
  60. blockdev-nbd.c
  61. blockdev.c
  62. blockjob.c
  63. bootdevice.c
  64. bt-host.c
  65. bt-vhci.c
  66. Changelog
  67. CODING_STYLE
  68. configure
  69. COPYING
  70. COPYING.LIB
  71. cpus-common.c
  72. cpus.c
  73. device-hotplug.c
  74. device_tree.c
  75. disas.c
  76. dma-helpers.c
  77. dump.c
  78. exec.c
  79. gdbstub.c
  80. gitdm.config
  81. HACKING
  82. hmp-commands-info.hx
  83. hmp-commands.hx
  84. hmp.c
  85. hmp.h
  86. ioport.c
  87. iothread.c
  88. job-qmp.c
  89. job.c
  90. LICENSE
  91. MAINTAINERS
  92. Makefile
  93. Makefile.objs
  94. Makefile.target
  95. memory.c
  96. memory_ldst.inc.c
  97. memory_mapping.c
  98. module-common.c
  99. monitor.c
  100. numa.c
  101. os-posix.c
  102. os-win32.c
  103. qdev-monitor.c
  104. qdict-test-data.txt
  105. qemu-bridge-helper.c
  106. qemu-deprecated.texi
  107. qemu-doc.texi
  108. qemu-edid.c
  109. qemu-ga.texi
  110. qemu-img-cmds.hx
  111. qemu-img.c
  112. qemu-img.texi
  113. qemu-io-cmds.c
  114. qemu-io.c
  115. qemu-keymap.c
  116. qemu-nbd.c
  117. qemu-nbd.texi
  118. qemu-option-trace.texi
  119. qemu-options-wrapper.h
  120. qemu-options.h
  121. qemu-options.hx
  122. qemu-seccomp.c
  123. qemu-tech.texi
  124. qemu.nsi
  125. qemu.sasl
  126. qmp.c
  127. qtest.c
  128. README
  129. replication.c
  130. replication.h
  131. rules.mak
  132. thunk.c
  133. tpm.c
  134. trace-events
  135. VERSION
  136. version.rc
  137. vl.c
  138. win_dump.c
  139. win_dump.h