commit 5ab1c032e6eea810142eb918c57222464482756f
author Dehan Meng <demeng@redhat.com> Thu Nov 07 12:21:55 2024 +0200
committer Konstantin Kostiuk <kkostiuk@redhat.com> Thu Nov 07 12:28:20 2024 +0200
tree 4477aee687a73383dab1d5212ff97267065e17f2
parent ccc2dfab57bfe4fdd02288761a7e7482f352bfcc

qemu-ga: Avoiding freeing line prematurely

It's now only freed at the end of the function.

Signed-off-by: Dehan Meng <demeng@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Message-ID: <20241107102155.57573-4-kkostiuk@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>

qga/commands-linux.c

diff --git a/qga/commands-linux.c b/qga/commands-linux.c
index b0704ad..cf077eb 100644
--- a/qga/commands-linux.c
+++ b/qga/commands-linux.c
@@ -2138,7 +2138,6 @@
         fp = fopen(route_files[i], "r");
         if (fp == NULL) {
             error_setg_errno(errp, errno, "open(\"%s\")", route_files[i]);
-            free(line);
             continue;
         }
 
@@ -2212,9 +2211,9 @@
             route = NULL;
         }
 
-        free(line);
         fclose(fp);
     }
 
+    free(line);
     return head;
 }