commit 589f20dccd94f6fab3cd3d2e0d21aae0c7210d12
author Alberto Garcia <berto@igalia.com> Thu Sep 06 12:37:02 2018 +0300
committer Kevin Wolf <kwolf@redhat.com> Mon Oct 01 12:51:11 2018 +0200
tree bc1d7ad3d838794853db6a0ec42a5980196e06f3
parent a8003ec40d0755228b646408d653bf0969d6ac33

file-posix: x-check-cache-dropped should default to false on reopen

The default value of x-check-cache-dropped is false. There's no reason
to use the previous value as a default in raw_reopen_prepare() because
bdrv_reopen_queue_child() already takes care of putting the old
options in the BDRVReopenState.options QDict.

If x-check-cache-dropped was previously set but is now missing from
the reopen QDict then it should be reset to false.

Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>

block/file-posix.c

diff --git a/block/file-posix.c b/block/file-posix.c
index 327f39c..bc5e545 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -850,7 +850,7 @@
     }
 
     rs->check_cache_dropped = qemu_opt_get_bool(opts, "x-check-cache-dropped",
-                                                s->check_cache_dropped);
+                                                false);
 
     if (s->type == FTYPE_CD) {
         rs->open_flags |= O_NONBLOCK;