Google Git
Sign in
qemu / qemu / 521534df57cc0bee7b0da9e69fbbaa7149036ddb
commit521534df57cc0bee7b0da9e69fbbaa7149036ddb[log] [tgz]
authorZihao Chang <changzihao1@huawei.com>Mon Jan 11 21:19:11 2021 +0800
committerGerd Hoffmann <kraxel@redhat.com>Fri Jan 15 11:22:42 2021 +0100
tree239e099844b291d1bbf84d927701645e92ea972e
parentcab82424f6f246e1ef51bb6b10fbb5114e166aaf [diff]
vnc: fix unfinalized tlscreds for VncDisplay

In vnc_display_open(), if tls-creds is enabled, do object_ref(object
ref 1->2) for tls-creds. While in vnc_display_close(), object_unparent
sets object ref to 1(2->1) and  unparent the object for root.
Problem:
1. the object can not be found from the objects_root, while the object
is not finalized.
2. the qemu_opts of tls-creds(id: creds0) is not deleted, so new tls
object with the same id(creds0) can not be delete & add.

Signed-off-by: Zihao Chang <changzihao1@huawei.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20210111131911.805-1-changzihao1@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
1 file changed
tree: 239e099844b291d1bbf84d927701645e92ea972e
  1. .github/
  2. .gitlab-ci.d/
  3. accel/
  4. audio/
  5. authz/
  6. backends/
  7. block/
  8. bsd-user/
  9. chardev/
  10. contrib/
  11. crypto/
  12. default-configs/
  13. disas/
  14. docs/
  15. dump/
  16. fpu/
  17. fsdev/
  18. gdb-xml/
  19. hw/
  20. include/
  21. io/
  22. libdecnumber/
  23. linux-headers/
  24. linux-user/
  25. migration/
  26. monitor/
  27. nbd/
  28. net/
  29. pc-bios/
  30. plugins/
  31. po/
  32. python/
  33. qapi/
  34. qga/
  35. qobject/
  36. qom/
  37. replay/
  38. roms/
  39. scripts/
  40. scsi/
  41. softmmu/
  42. storage-daemon/
  43. stubs/
  44. subprojects/
  45. target/
  46. tcg/
  47. tests/
  48. tools/
  49. trace/
  50. ui/
  51. util/
  52. capstone
  53. dtc
  54. meson
  55. slirp
  56. .cirrus.yml
  57. .dir-locals.el
  58. .editorconfig
  59. .exrc
  60. .gdbinit
  61. .gitattributes
  62. .gitignore
  63. .gitlab-ci.yml
  64. .gitmodules
  65. .gitpublish
  66. .mailmap
  67. .patchew.yml
  68. .readthedocs.yml
  69. .shippable.yml
  70. .travis.yml
  71. block.c
  72. blockdev-nbd.c
  73. blockdev.c
  74. blockjob.c
  75. CODING_STYLE.rst
  76. configure
  77. COPYING
  78. COPYING.LIB
  79. cpu.c
  80. cpus-common.c
  81. disas.c
  82. exec-vary.c
  83. gdbstub.c
  84. gitdm.config
  85. hmp-commands-info.hx
  86. hmp-commands.hx
  87. iothread.c
  88. job-qmp.c
  89. job.c
  90. Kconfig
  91. Kconfig.host
  92. LICENSE
  93. MAINTAINERS
  94. Makefile
  95. memory_ldst.c.inc
  96. meson.build
  97. meson_options.txt
  98. module-common.c
  99. os-posix.c
  100. os-win32.c
  101. qemu-bridge-helper.c
  102. qemu-edid.c
  103. qemu-img-cmds.hx
  104. qemu-img.c
  105. qemu-io-cmds.c
  106. qemu-io.c
  107. qemu-keymap.c
  108. qemu-nbd.c
  109. qemu-options-wrapper.h
  110. qemu-options.h
  111. qemu-options.hx
  112. qemu.nsi
  113. qemu.sasl
  114. README.rst
  115. replication.c
  116. replication.h
  117. thunk.c
  118. trace-events
  119. VERSION
  120. version.rc