commit 4c235193a2132a1d8e9bd78a21d90153c1f662ff
author Philippe Mathieu-Daudé <philmd@redhat.com> Fri Feb 28 11:07:23 2020 +0100
committer Markus Armbruster <armbru@redhat.com> Mon Mar 09 13:36:15 2020 +0100
tree 2430ebc3c6e339a1b76630fffff69e9e956a6c18
parent 67f17e23baca5dd545fe98b01169cc351a70fe35

chardev: Improve error report by calling error_setg_win32()

Use error_setg_win32() which adds a hint similar to strerror(errno)).

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200228100726.8414-2-philmd@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>

chardev/char-pipe.c

diff --git a/chardev/char-pipe.c b/chardev/char-pipe.c
index 94d714f..fd12c9e 100644
--- a/chardev/char-pipe.c
+++ b/chardev/char-pipe.c
@@ -70,7 +70,7 @@
                               MAXCONNECT, NSENDBUF, NRECVBUF, NTIMEOUT, NULL);
     g_free(openname);
     if (s->file == INVALID_HANDLE_VALUE) {
-        error_setg(errp, "Failed CreateNamedPipe (%lu)", GetLastError());
+        error_setg_win32(errp, GetLastError(), "Failed CreateNamedPipe");
         s->file = NULL;
         goto fail;
     }

chardev/char-win.c

diff --git a/chardev/char-win.c b/chardev/char-win.c
index 34825f6..d4fb44c 100644
--- a/chardev/char-win.c
+++ b/chardev/char-win.c
@@ -96,7 +96,7 @@
     s->file = CreateFile(filename, GENERIC_READ | GENERIC_WRITE, 0, NULL,
                       OPEN_EXISTING, FILE_FLAG_OVERLAPPED, 0);
     if (s->file == INVALID_HANDLE_VALUE) {
-        error_setg(errp, "Failed CreateFile (%lu)", GetLastError());
+        error_setg_win32(errp, GetLastError(), "Failed CreateFile");
         s->file = NULL;
         goto fail;
     }