commit 4ba664cb0aabecfc425aa94cd025c515e6251539
author Volker Rümelin <vr_qemu@t-online.de> Sun Apr 05 09:50:15 2020 +0200
committer Gerd Hoffmann <kraxel@redhat.com> Mon Apr 06 13:29:53 2020 +0200
tree 0caba46dea8c7e0b01e07dc9769cb638416e04c7
parent 146aa0f104bb3bf88e43c4082a0bfc4bbda4fbd8

dsoundaudio: fix never-ending playback loop

Currently the DirectSound backend fails to stop audio playback
in dsound_enable_out(). To detect a lost buffer condition
dsound_get_status_out() incorrectly uses the error code
DSERR_BUFFERLOST instead of flag DSBSTATUS_BUFFERLOST as a mask
and returns with an error. As a result dsound_enable_out()
returns early and doesn't stop playback.

To reproduce the bug start qemu on a Windows host with
-soundhw pcspk -audiodev dsound,id=audio0. On the guest
FreeDOS 1.2 command line enter beep. The image Day 1 - F-Bird
from the QEMU Advent Calendar 2018 shows the bug as well.

Buglink: https://bugs.launchpad.net/qemu/+bug/1699628
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 20200405075017.9901-1-vr_qemu@t-online.de
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>