commit 49fbc7236dd203f9c6afa87454f603a9236a0b3b
author Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Thu Dec 05 20:46:17 2019 +0300
committer Markus Armbruster <armbru@redhat.com> Wed Dec 18 08:36:16 2019 +0100
tree 850cd538066053acd9954beac48ddbb1586673f4
parent 33c9642f657193bc478c96f08434ae746397b70e

error: make Error **errp const where it is appropriate

Mostly, Error ** is for returning error from the function, so the
callee sets it. However these three functions get already filled errp
parameter. They don't change the pointer itself, only change the
internal state of referenced Error object. So we can make it
Error *const * errp, to stress the behavior. It will also help
coccinelle script (in future) to distinguish such cases from common
errp usage.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20191205174635.18758-4-vsementsov@virtuozzo.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Commit message typo fixed]
Signed-off-by: Markus Armbruster <armbru@redhat.com>

util/error.c

diff --git a/util/error.c b/util/error.c
index d4532ce..b6c89d1 100644
--- a/util/error.c
+++ b/util/error.c
@@ -121,7 +121,7 @@
                               "Could not open '%s'", filename);
 }
 
-void error_vprepend(Error **errp, const char *fmt, va_list ap)
+void error_vprepend(Error *const *errp, const char *fmt, va_list ap)
 {
     GString *newmsg;
 
@@ -136,7 +136,7 @@
     (*errp)->msg = g_string_free(newmsg, 0);
 }
 
-void error_prepend(Error **errp, const char *fmt, ...)
+void error_prepend(Error *const *errp, const char *fmt, ...)
 {
     va_list ap;
 
@@ -145,7 +145,7 @@
     va_end(ap);
 }
 
-void error_append_hint(Error **errp, const char *fmt, ...)
+void error_append_hint(Error *const *errp, const char *fmt, ...)
 {
     va_list ap;
     int saved_errno = errno;