commit 47e8dd8fe9d83e8b51d40c2b87d7983bd0a78206
author Pavel Borzenkov <pavel.borzenkov@gmail.com> Mon Oct 31 22:53:38 2011 +0400
committer Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> Mon Nov 07 08:01:15 2011 +0000
tree d4f0aae3104802dd9166634db2bbd04c603876cc
parent ba7806ad92a2f6b1625cfa67d44dc1b71e3be44e

cmd: Fix potential memory leak

Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

cmd.c

diff --git a/cmd.c b/cmd.c
index 75415d8..0806e18 100644
--- a/cmd.c
+++ b/cmd.c
@@ -329,16 +329,21 @@
     int c = 0;
     char *p;
     char **rval = calloc(sizeof(char *), 1);
+    char **tmp;
 
     while (rval && (p = qemu_strsep(&input, " ")) != NULL) {
         if (!*p) {
             continue;
         }
         c++;
-        rval = realloc(rval, sizeof(*rval) * (c + 1));
-        if (!rval) {
+        tmp = realloc(rval, sizeof(*rval) * (c + 1));
+        if (!tmp) {
+            free(rval);
+            rval = NULL;
             c = 0;
             break;
+        } else {
+            rval = tmp;
         }
         rval[c - 1] = p;
         rval[c] = NULL;