tree 2cf2b2a0a8e525a7a82a7d2e8c329ef8f0c67672
parent 5375af3cd7b8adcc10c18d8083b7be63976c9645
author Eric Blake <eblake@redhat.com> 1587405188 -0500
committer Eric Blake <eblake@redhat.com> 1588622075 -0500

tools: Fix use of fcntl(F_SETFD) during socket activation

Blindly setting FD_CLOEXEC without a read-modify-write will
inadvertently clear any other intentionally-set bits, such as a
proposed new bit for designating a fd that must behave in 32-bit mode.
However, we cannot use our wrapper qemu_set_cloexec(), because that
wrapper intentionally abort()s on failure, whereas the probe here
intentionally tolerates failure to deal with incorrect socket
activation gracefully.  Instead, fix the code to do the proper
read-modify-write.

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200420175309.75894-3-eblake@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>