commit 45724d6d02383b0d7d4a90e05787fca7c55cb070
author Stefan Weil <sw@weilnetz.de> Sat Sep 01 11:06:45 2012 +0200
committer Kevin Wolf <kwolf@redhat.com> Wed Sep 12 15:50:09 2012 +0200
tree da5b37d1e41a11b8aac0569c3319400f5bee9019
parent 1e53537fdaa4657d11f130a0f2673fcfb1956381

block/curl: Fix wrong free statement

Report from smatch:
block/curl.c:546 curl_close(21) info: redundant null check on s->url calling free()

The check was redundant, and free was also wrong because the memory
was allocated using g_strdup.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>

block/curl.c

diff --git a/block/curl.c b/block/curl.c
index e7c3634..c1074cd 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -542,8 +542,7 @@
     }
     if (s->multi)
         curl_multi_cleanup(s->multi);
-    if (s->url)
-        free(s->url);
+    g_free(s->url);
 }
 
 static int64_t curl_getlength(BlockDriverState *bs)