commit 40ff6d7e8dceca227e7f8a3e8e0d58b2c66d19b4
author Kevin Wolf <kwolf@redhat.com> Wed Dec 02 12:24:42 2009 +0100
committer Anthony Liguori <aliguori@us.ibm.com> Thu Dec 03 11:45:50 2009 -0600
tree 98d560a0de229f27a66f637cfcadbb1672e68cc3
parent 12c09b8ce22d74f78ff50f95676cbe4f501752ae

Don't leak file descriptors

We're leaking file descriptors to child processes. Set FD_CLOEXEC on file
descriptors that don't need to be passed to children to stop this misbehaviour.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

migration-tcp.c

diff --git a/migration-tcp.c b/migration-tcp.c
index b77ed87..2cfa8cb 100644
--- a/migration-tcp.c
+++ b/migration-tcp.c
@@ -105,7 +105,7 @@
     s->state = MIG_STATE_ACTIVE;
     s->mon = NULL;
     s->bandwidth_limit = bandwidth_limit;
-    s->fd = socket(PF_INET, SOCK_STREAM, 0);
+    s->fd = qemu_socket(PF_INET, SOCK_STREAM, 0);
     if (s->fd == -1) {
         qemu_free(s);
         return NULL;
@@ -146,7 +146,7 @@
     int c, ret;
 
     do {
-        c = accept(s, (struct sockaddr *)&addr, &addrlen);
+        c = qemu_accept(s, (struct sockaddr *)&addr, &addrlen);
     } while (c == -1 && socket_error() == EINTR);
 
     dprintf("accepted migration\n");
@@ -193,7 +193,7 @@
         return -EINVAL;
     }
 
-    s = socket(PF_INET, SOCK_STREAM, 0);
+    s = qemu_socket(PF_INET, SOCK_STREAM, 0);
     if (s == -1)
         return -socket_error();