)]}'
{
  "commit": "3ffa21d293bf5e4f997ba117ee3e943344b71044",
  "tree": "240051d2497571e50376fe3d1c316a3326869b5c",
  "parents": [
    "79d7e60c326bcb9d165e5d52a29b238937bedd8d"
  ],
  "author": {
    "name": "Peter Maydell",
    "email": "peter.maydell@linaro.org",
    "time": "Thu Jul 10 17:15:52 2025 +0100"
  },
  "committer": {
    "name": "Thomas Huth",
    "email": "thuth@redhat.com",
    "time": "Fri Jul 11 09:42:47 2025 +0200"
  },
  "message": "hw/s390x/s390-pci-bus.c: Use g_assert_not_reached() in functions taking an ett\n\nThe s390-pci-bus.c code, Coverity complains about a possible overflow\nbecause get_table_index() can return -1 if the ett value passed in is\nnot one of the three permitted ZPCI_ETT_PT, ZPCI_ETT_ST, ZPCI_ETT_RT,\nbut the caller in table_translate() doesn\u0027t check this and instead\nuses the return value directly in a calculation of the guest address\nto read from.\n\nIn fact this case cannot happen, because:\n * get_table_index() is called only from table_translate()\n * the only caller of table_translate() loops through the ett values\n   in the order RT, ST, PT until table_translate() returns 0\n * table_translate() will return 0 for the error cases and when\n   translate_iscomplete() returns true\n * translate_iscomplete() is always true for ZPCI_ETT_PT\n\nSo table_translate() is always called with a valid ett value.\n\nInstead of having the various functions called from table_translate()\nreturn a default or dummy value when the ett argument is out of range,\nuse g_assert_not_reached() to indicate that this is impossible.\n\nCoverity: CID 1547609\nSigned-off-by: Peter Maydell \u003cpeter.maydell@linaro.org\u003e\nReviewed-by: Matthew Rosato \u003cmjrosato@linux.ibm.com\u003e\nReviewed-by: Halil Pasic \u003cpasic@linux.ibm.com\u003e\nMessage-ID: \u003c20250710161552.1287399-1-peter.maydell@linaro.org\u003e\nSigned-off-by: Thomas Huth \u003cthuth@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "e6aa44531f672f01cfa122b0f8b2d8779e91992e",
      "old_mode": 33188,
      "old_path": "hw/s390x/s390-pci-bus.c",
      "new_id": "f87d2748b637800922e6c7394195c5dfaf99a167",
      "new_mode": 33188,
      "new_path": "hw/s390x/s390-pci-bus.c"
    }
  ]
}