commit 3dcf56e625c684178c0062d845f9fe05ecce346f
author Eric Blake <eblake@redhat.com> Tue Feb 09 09:27:59 2021 -0600
committer Eric Blake <eblake@redhat.com> Fri Feb 12 07:42:08 2021 -0600
tree d117ef75bc8369503536b489a207e04fd22ad0dc
parent 582d4210eb2f2ab5baac328fe4b479cd86da1647

qemu-nbd: Permit --shared=0 for unlimited clients

This gives us better feature parity with QMP nbd-server-start, where
max-connections defaults to 0 for unlimited.

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20210209152759.209074-3-eblake@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

qemu-nbd.c

diff --git a/qemu-nbd.c b/qemu-nbd.c
index 1a340ea..b1b9430 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -328,7 +328,7 @@
 
 static int nbd_can_accept(void)
 {
-    return state == RUNNING && nb_fds < shared;
+    return state == RUNNING && (shared == 0 || nb_fds < shared);
 }
 
 static void nbd_update_server_watch(void);
@@ -707,7 +707,7 @@
             break;
         case 'e':
             if (qemu_strtoi(optarg, NULL, 0, &shared) < 0 ||
-                shared < 1) {
+                shared < 0) {
                 error_report("Invalid shared device number '%s'", optarg);
                 exit(EXIT_FAILURE);
             }
@@ -966,7 +966,7 @@
     if (socket_activation == 0) {
         int backlog;
 
-        if (persistent) {
+        if (persistent || shared == 0) {
             backlog = SOMAXCONN;
         } else {
             backlog = MIN(shared, SOMAXCONN);