commit 3804e3cf540af25a01d0d418a5a1d4f78c2574ff
author Kevin Wolf <kwolf@redhat.com> Mon Sep 11 11:46:12 2023 +0200
committer Kevin Wolf <kwolf@redhat.com> Wed Sep 20 17:46:01 2023 +0200
tree 7a3fb1b6ec027501a297d2cacbe31e00ecaaa8c9
parent afdaeb9ea06ea641ccc4226964b8e278af5e7685

block: Mark bdrv_parent_perms_conflict() and callers GRAPH_RDLOCK

The function reads the parents list, so it needs to hold the graph lock.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20230911094620.45040-14-kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>

block/vmdk.c

diff --git a/block/vmdk.c b/block/vmdk.c
index 58ce290..84185b7 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -1309,6 +1309,8 @@
     BDRVVmdkState *s = bs->opaque;
     uint32_t magic;
 
+    GRAPH_RDLOCK_GUARD_MAINLOOP();
+
     ret = bdrv_open_file_child(NULL, options, "file", bs, errp);
     if (ret < 0) {
         return ret;