Google Git
Sign in
qemu / qemu / 3428455df9302b2b924e380cb90a77ca1ce5001e
commit3428455df9302b2b924e380cb90a77ca1ce5001e[log] [tgz]
authorKevin Wolf <kwolf@redhat.com>Tue Nov 17 17:30:44 2020 +0100
committerDaniel P. Berrangé <berrange@redhat.com>Wed Nov 18 10:51:35 2020 +0000
treeee82f874bae66e84b9c908e738c718f1b9f77c86
parent8e26ae7bb58d10c04599eabd265217da050514a4 [diff]
authz-pam: Check that 'service' property is set

If the 'service' property is not set, we'll call pam_start() with a NULL
pointer for the service name. This fails and leaves a message like this
in the syslog:

qemu-storage-daemon[294015]: PAM pam_start: invalid argument: service == NULL

Make specifying the property mandatory and catch the error already
during the creation of the object.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
1 file changed
tree: ee82f874bae66e84b9c908e738c718f1b9f77c86
  1. .github/
  2. .gitlab-ci.d/
  3. accel/
  4. audio/
  5. authz/
  6. backends/
  7. block/
  8. bsd-user/
  9. chardev/
  10. contrib/
  11. crypto/
  12. default-configs/
  13. disas/
  14. docs/
  15. dump/
  16. fpu/
  17. fsdev/
  18. gdb-xml/
  19. hw/
  20. include/
  21. io/
  22. libdecnumber/
  23. linux-headers/
  24. linux-user/
  25. migration/
  26. monitor/
  27. nbd/
  28. net/
  29. pc-bios/
  30. plugins/
  31. po/
  32. python/
  33. qapi/
  34. qga/
  35. qobject/
  36. qom/
  37. replay/
  38. roms/
  39. scripts/
  40. scsi/
  41. softmmu/
  42. storage-daemon/
  43. stubs/
  44. target/
  45. tcg/
  46. tests/
  47. tools/
  48. trace/
  49. ui/
  50. util/
  51. capstone
  52. dtc
  53. meson
  54. slirp
  55. .cirrus.yml
  56. .dir-locals.el
  57. .editorconfig
  58. .exrc
  59. .gdbinit
  60. .gitignore
  61. .gitlab-ci.yml
  62. .gitmodules
  63. .gitpublish
  64. .mailmap
  65. .patchew.yml
  66. .readthedocs.yml
  67. .shippable.yml
  68. .travis.yml
  69. block.c
  70. blockdev-nbd.c
  71. blockdev.c
  72. blockjob.c
  73. CODING_STYLE.rst
  74. configure
  75. COPYING
  76. COPYING.LIB
  77. cpu.c
  78. cpus-common.c
  79. disas.c
  80. exec-vary.c
  81. gdbstub.c
  82. gitdm.config
  83. hmp-commands-info.hx
  84. hmp-commands.hx
  85. iothread.c
  86. job-qmp.c
  87. job.c
  88. Kconfig
  89. Kconfig.host
  90. LICENSE
  91. MAINTAINERS
  92. Makefile
  93. memory_ldst.c.inc
  94. meson.build
  95. meson_options.txt
  96. module-common.c
  97. os-posix.c
  98. os-win32.c
  99. qemu-bridge-helper.c
  100. qemu-edid.c
  101. qemu-img-cmds.hx
  102. qemu-img.c
  103. qemu-io-cmds.c
  104. qemu-io.c
  105. qemu-keymap.c
  106. qemu-nbd.c
  107. qemu-options-wrapper.h
  108. qemu-options.h
  109. qemu-options.hx
  110. qemu.nsi
  111. qemu.sasl
  112. README.rst
  113. replication.c
  114. replication.h
  115. thunk.c
  116. trace-events
  117. VERSION
  118. version.rc