commit 32c16620dda8ba16f6d6bcd20efefdec8975af77
author Markus Armbruster <armbru@redhat.com> Fri Jan 11 11:25:00 2013 +0100
committer Michael Roth <mdroth@linux.vnet.ibm.com> Mon Jan 14 12:07:54 2013 -0600
tree d6a4f997b9ddd479e0b4bf936f9a9a46c4a27d3f
parent 03ac10f166b790cb66804e512abec6d002cd8481

qemu-ga: Plug fd leak on ga_channel_listen_accept() error path

Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>

qga/channel-posix.c

diff --git a/qga/channel-posix.c b/qga/channel-posix.c
index ca9e4aa..9a5c05d 100644
--- a/qga/channel-posix.c
+++ b/qga/channel-posix.c
@@ -46,6 +46,7 @@
     ret = ga_channel_client_add(c, client_fd);
     if (ret) {
         g_warning("error setting up connection");
+        close(client_fd);
         goto out;
     }
     accepted = true;