commit 327adeecdde6f2b12ba32d0b886a720e40900b31
author Marc-André Lureau <marcandre.lureau@redhat.com> Wed Mar 23 19:57:37 2022 +0400
committer Paolo Bonzini <pbonzini@redhat.com> Wed Apr 06 14:31:43 2022 +0200
tree 104987acb623b51dc2789e226fbcd98b13d36560
parent 89fc45d5c64235cb3262a431b3b9168ccdbaef7b

include: move os_*() to os-foo.h

For consistency with other os_ functions that do not have POSIX
implementation, declare an inline function for the stub in os-win32.h.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20220323155743.1585078-27-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

include/qemu-common.h

diff --git a/include/qemu-common.h b/include/qemu-common.h
index 1fbc20e..a271cac 100644
--- a/include/qemu-common.h
+++ b/include/qemu-common.h
@@ -24,10 +24,6 @@
 int qemu_main(int argc, char **argv, char **envp);
 #endif
 
-/* OS specific functions */
-void os_setup_early_signal_handling(void);
-int os_parse_cmd_args(int index, const char *optarg);
-
 void page_size_init(void);
 
 #endif

include/sysemu/os-posix.h

diff --git a/include/sysemu/os-posix.h b/include/sysemu/os-posix.h
index 23bd454..58de7c9 100644
--- a/include/sysemu/os-posix.h
+++ b/include/sysemu/os-posix.h
@@ -42,7 +42,9 @@
 extern "C" {
 #endif
 
+int os_parse_cmd_args(int index, const char *optarg);
 void os_set_line_buffering(void);
+void os_setup_early_signal_handling(void);
 void os_set_proc_name(const char *s);
 void os_setup_signal_handling(void);
 void os_daemonize(void);

include/sysemu/os-win32.h

diff --git a/include/sysemu/os-win32.h b/include/sysemu/os-win32.h
index 1351d1d..3c74a78 100644
--- a/include/sysemu/os-win32.h
+++ b/include/sysemu/os-win32.h
@@ -62,8 +62,10 @@
 static inline void os_setup_signal_handling(void) {}
 static inline void os_daemonize(void) {}
 static inline void os_setup_post(void) {}
-void os_set_line_buffering(void);
 static inline void os_set_proc_name(const char *dummy) {}
+static inline int os_parse_cmd_args(int index, const char *optarg) { return -1; }
+void os_set_line_buffering(void);
+void os_setup_early_signal_handling(void);
 
 int getpagesize(void);
 

os-win32.c

diff --git a/os-win32.c b/os-win32.c
index e31c921..6f21b57 100644
--- a/os-win32.c
+++ b/os-win32.c
@@ -61,12 +61,3 @@
     setbuf(stdout, NULL);
     setbuf(stderr, NULL);
 }
-
-/*
- * Parse OS specific command line options.
- * return 0 if option handled, -1 otherwise
- */
-int os_parse_cmd_args(int index, const char *optarg)
-{
-    return -1;
-}