commit 2cfa571f79c58c56fe0711e8306d43d3bce591f7
author Mark McLoughlin <markmc@redhat.com> Tue Oct 06 12:17:02 2009 +0100
committer Anthony Liguori <aliguori@us.ibm.com> Tue Oct 06 14:36:11 2009 -0500
tree afb4dbebce37036c79e031216fb1f33ae6a1e25c
parent b386becf368ce2757db46843e39218481ad34cd9

Make qemu_opts_parse() handle empty strings

Rather than making callers explicitly handle empty strings by using
qemu_opts_create(), we can easily have qemu_opts_parse() handle
empty parameter strings.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

qemu-option.c

diff --git a/qemu-option.c b/qemu-option.c
index 293f94c..735259f 100644
--- a/qemu-option.c
+++ b/qemu-option.c
@@ -712,8 +712,7 @@
     char option[128], value[128];
     const char *p,*pe,*pc;
 
-    p = params;
-    for(;;) {
+    for (p = params; *p != '\0'; p++) {
         pe = strchr(p, '=');
         pc = strchr(p, ',');
         if (!pe || (pc && pc < pe)) {
@@ -750,7 +749,6 @@
         if (*p != ',') {
             break;
         }
-        p++;
     }
     return 0;
 }