commit 2bbb9c2f7f36d0457cda5f27d7e4422219b3acd8
author Isaku Yamahata <yamahata@valinux.co.jp> Thu Sep 09 11:48:56 2010 +0900
committer Michael S. Tsirkin <mst@redhat.com> Mon Sep 13 21:03:51 2010 +0200
tree ff7c7a1a9a26e84629283df6ab7ae3c89d594dd9
parent 5a9ff3819a1023b63b94ad4fb82da973f93f65d0

pci: don't ignore invalid parameter for pci_register_bar().

Abort when invalid value for region_num is passed to pci_register_bar.
That is caller's bug. Abort instead of silently ignoring invalid value.

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

hw/pci.c

diff --git a/hw/pci.c b/hw/pci.c
index c28b8a1..8f48d9b 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -765,9 +765,8 @@
     uint32_t addr;
     uint64_t wmask;
 
-    if ((unsigned int)region_num >= PCI_NUM_REGIONS)
-        return;
-
+    assert(region_num >= 0);
+    assert(region_num < PCI_NUM_REGIONS);
     if (size & (size-1)) {
         fprintf(stderr, "ERROR: PCI region size must be pow2 "
                     "type=0x%x, size=0x%"FMT_PCIBUS"\n", type, size);