commit 2b3912f1350971fbc2c04d986a1d0c60ae757c78
author Kevin Wolf <kwolf@redhat.com> Fri Sep 29 16:51:39 2023 +0200
committer Kevin Wolf <kwolf@redhat.com> Thu Oct 12 16:31:33 2023 +0200
tree 968e32867ca0d1a1c3579adb014e07595d4ba1aa
parent 0e6bad1f2171385ec3ab7b9721dacfdb7dda70d7

block: Mark bdrv_first_blk() and bdrv_is_root_node() GRAPH_RDLOCK

This adds GRAPH_RDLOCK annotations to declare that callers of
bdrv_first_blk() and bdrv_is_root_node() need to hold a reader lock
for the graph. These functions are the only functions in block-backend.c
that access the parent list of a node.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20230929145157.45443-5-kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>

migration/migration-hmp-cmds.c

diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
index c115ef2..5b25ba2 100644
--- a/migration/migration-hmp-cmds.c
+++ b/migration/migration-hmp-cmds.c
@@ -794,6 +794,8 @@
     BlockDriverState *bs;
     BdrvNextIterator it;
 
+    GRAPH_RDLOCK_GUARD_MAINLOOP();
+
     len = strlen(str);
     readline_set_completion_index(rs, len);