Google Git
Sign in
qemu / qemu / 27539ac53154cf9da6990ce9bec1064d37cf2b1d
commit27539ac53154cf9da6990ce9bec1064d37cf2b1d[log] [tgz]
authorJeff Cody <jcody@redhat.com>Mon Aug 07 08:38:20 2017 -0400
committerKevin Wolf <kwolf@redhat.com>Tue Aug 08 14:37:00 2017 +0200
tree2af317fda58a7b406f29c35d4032dd436f51d8bb
parent3f910692c287e1c611c00e763ebeb95ed0e017f8 [diff]
block/vhdx: check for offset overflow to bdrv_truncate()

VHDX uses uint64_t types for most offsets, following the VHDX spec.
However, bdrv_truncate() takes an int64_t value for the truncating
offset.  Check for overflow before calling bdrv_truncate().

While we are here, replace the bit shifting with QEMU_ALIGN_UP as well.

N.B.: For a compliant image this is not an issue, as the maximum VHDX
image size is defined per the spec to be 64TB.

Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2 files changed
tree: 2af317fda58a7b406f29c35d4032dd436f51d8bb
  1. accel/
  2. audio/
  3. backends/
  4. block/
  5. bsd-user/
  6. chardev/
  7. contrib/
  8. crypto/
  9. default-configs/
  10. disas/
  11. docs/
  12. fpu/
  13. fsdev/
  14. gdb-xml/
  15. hw/
  16. include/
  17. io/
  18. libdecnumber/
  19. linux-headers/
  20. linux-user/
  21. migration/
  22. nbd/
  23. net/
  24. pc-bios/
  25. po/
  26. qapi/
  27. qga/
  28. qobject/
  29. qom/
  30. replay/
  31. roms/
  32. scripts/
  33. slirp/
  34. stubs/
  35. target/
  36. tcg/
  37. tests/
  38. trace/
  39. ui/
  40. util/
  41. dtc
  42. pixman
  43. .dir-locals.el
  44. .editorconfig
  45. .exrc
  46. .gdbinit
  47. .gitignore
  48. .gitmodules
  49. .mailmap
  50. .shippable.yml
  51. .travis.yml
  52. arch_init.c
  53. atomic_template.h
  54. balloon.c
  55. block.c
  56. blockdev-nbd.c
  57. blockdev.c
  58. blockjob.c
  59. bootdevice.c
  60. bt-host.c
  61. bt-vhci.c
  62. Changelog
  63. CODING_STYLE
  64. configure
  65. COPYING
  66. COPYING.LIB
  67. cpus-common.c
  68. cpus.c
  69. device-hotplug.c
  70. device_tree.c
  71. disas.c
  72. dma-helpers.c
  73. dump.c
  74. exec.c
  75. gdbstub.c
  76. HACKING
  77. hax-stub.c
  78. hmp-commands-info.hx
  79. hmp-commands.hx
  80. hmp.c
  81. hmp.h
  82. ioport.c
  83. iothread.c
  84. LICENSE
  85. MAINTAINERS
  86. Makefile
  87. Makefile.objs
  88. Makefile.target
  89. memory.c
  90. memory_ldst.inc.c
  91. memory_mapping.c
  92. module-common.c
  93. monitor.c
  94. numa.c
  95. os-posix.c
  96. os-win32.c
  97. qapi-schema.json
  98. qdev-monitor.c
  99. qdict-test-data.txt
  100. qemu-bridge-helper.c
  101. qemu-doc.texi
  102. qemu-ga.texi
  103. qemu-img-cmds.hx
  104. qemu-img.c
  105. qemu-img.texi
  106. qemu-io-cmds.c
  107. qemu-io.c
  108. qemu-nbd.c
  109. qemu-nbd.texi
  110. qemu-option-trace.texi
  111. qemu-options-wrapper.h
  112. qemu-options.h
  113. qemu-options.hx
  114. qemu-seccomp.c
  115. qemu-tech.texi
  116. qemu.nsi
  117. qemu.sasl
  118. qmp.c
  119. qtest.c
  120. README
  121. replication.c
  122. replication.h
  123. rules.mak
  124. softmmu_template.h
  125. thunk.c
  126. tpm.c
  127. trace-events
  128. user-exec-stub.c
  129. user-exec.c
  130. VERSION
  131. version.rc
  132. vl.c