commit 272545cf215f183ecb84c1d0fca3fd38db806977
author Peter Maydell <peter.maydell@linaro.org> Mon Jun 05 14:55:54 2017 +0100
committer Kevin Wolf <kwolf@redhat.com> Fri Jun 09 13:46:20 2017 +0200
tree fc1cf0280bcd7a45290312a4293cc358746b6faf
parent c3971b883a596abc6af45f53d2f43fb2f59ccd3b

block/qcow.c: Fix memory leak in qcow_create()

Coverity points out that the code path in qcow_create() for
the magic "fat:" backing file name leaks the memory used to
store the filename (CID 1307771). Free the memory before
we overwrite the pointer.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>

block/qcow.c

diff --git a/block/qcow.c b/block/qcow.c
index 95ab123..7bd94dc 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -852,6 +852,7 @@
             header_size += backing_filename_len;
         } else {
             /* special backing file for vvfat */
+            g_free(backing_file);
             backing_file = NULL;
         }
         header.cluster_bits = 9; /* 512 byte cluster to avoid copying