commit 21d1683690e048663855dd6feb3034ab7c5039bc
author Zhang Yi <yi.z.zhang@linux.intel.com> Wed Jan 02 13:26:24 2019 +0800
committer Eduardo Habkost <ehabkost@redhat.com> Mon Jan 28 15:52:05 2019 -0200
tree cf82a89d43e63a6dbe896368f4cd6fd221c767b7
parent 2920bd644e8c2d21636a959a0cc717600913ad03

hostmem: add more information in error messages

When there are multiple memory backends in use, including the object type
and property name in the error message can help users to locate the error.

Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
Signed-off-by: Zhang Yi <yi.z.zhang@linux.intel.com>
Message-Id: <97d9193875747d8378c05b9e3b3cb39c1b7d2b4e.1546399191.git.yi.z.zhang@linux.intel.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
[ehabkost: reword commit message]
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

backends/hostmem.c

diff --git a/backends/hostmem.c b/backends/hostmem.c
index 0c8ef17..87b19d2 100644
--- a/backends/hostmem.c
+++ b/backends/hostmem.c
@@ -57,7 +57,8 @@
     uint64_t value;
 
     if (host_memory_backend_mr_inited(backend)) {
-        error_setg(&local_err, "cannot change property value");
+        error_setg(&local_err, "cannot change property %s of %s ",
+                   name, object_get_typename(obj));
         goto out;
     }
 
@@ -66,8 +67,9 @@
         goto out;
     }
     if (!value) {
-        error_setg(&local_err, "Property '%s.%s' doesn't take value '%"
-                   PRIu64 "'", object_get_typename(obj), name, value);
+        error_setg(&local_err,
+                   "property '%s' of %s doesn't take value '%" PRIu64 "'",
+                   name, object_get_typename(obj), value);
         goto out;
     }
     backend->size = value;