tree 3ab823ba59aabb965e1e08629253f2ea9c293e30
parent bef2ed3fd2454586a7c1132ad574b891741d12c6
author Marc-André Lureau <marcandre.lureau@redhat.com> 1509993552 +0100
committer Stefan Berger <stefanb@linux.vnet.ibm.com> 1513312754 -0500

tpm-passthrough: workaround a possible race

The TPM backend processing thread has common shared variable race
issues. (they should not be so easy to reach since guest interaction
with the device is slow compared to host emulation)

An obvious one is setting op_cancelled from device thread after
calling write(cancel_fd). The backend thread may return before the
device thread has set the variable. Instead set it before
cancellation. Even if the write() failed, the end result is command
get possibly cancelled (even if cancellation came from external
sources it doesn't matter much).

It's worth to consider removing the backend processing thread for now.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>