commit 20f46806b3858b92e9d1b5cf586558d62bd5a913
author Paolo Bonzini <pbonzini@redhat.com> Fri Mar 03 13:12:50 2023 +0100
committer Paolo Bonzini <pbonzini@redhat.com> Mon May 08 11:10:49 2023 +0200
tree 757482ed7bbfd33e45d60bda5952127fed0ccc04
parent 8f593ba9c5c96b1790cc6aceb95b5b83bbac92cd

tb-maint: do not use mb_read/mb_set

The load side can use a relaxed load, which will surely happen before
the work item is run by async_safe_run_on_cpu() or before double-checking
under mmap_lock.  The store side can use an atomic RMW operation.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

accel/tcg/tb-maint.c

diff --git a/accel/tcg/tb-maint.c b/accel/tcg/tb-maint.c
index cb1f806..0dd173f 100644
--- a/accel/tcg/tb-maint.c
+++ b/accel/tcg/tb-maint.c
@@ -746,7 +746,7 @@
 
     tcg_region_reset_all();
     /* XXX: flush processor icache at this point if cache flush is expensive */
-    qatomic_mb_set(&tb_ctx.tb_flush_count, tb_ctx.tb_flush_count + 1);
+    qatomic_inc(&tb_ctx.tb_flush_count);
 
 done:
     mmap_unlock();
@@ -758,7 +758,7 @@
 void tb_flush(CPUState *cpu)
 {
     if (tcg_enabled()) {
-        unsigned tb_flush_count = qatomic_mb_read(&tb_ctx.tb_flush_count);
+        unsigned tb_flush_count = qatomic_read(&tb_ctx.tb_flush_count);
 
         if (cpu_in_exclusive_context(cpu)) {
             do_tb_flush(cpu, RUN_ON_CPU_HOST_INT(tb_flush_count));