commit 1b3ff9feb942c2ad0b01ac931e99ad451ab0ef39
author Kevin Wolf <kwolf@redhat.com> Wed Dec 07 14:18:38 2022 +0100
committer Kevin Wolf <kwolf@redhat.com> Thu Dec 15 16:08:23 2022 +0100
tree 858cc22574ca231ebc61c3e1cc90bcb69097d210
parent 90830f595062ecf0d2c96049f5e01f3d37a2107f

block: GRAPH_RDLOCK for functions only called by co_wrappers

The generated coroutine wrappers already take care to take the lock in
the non-coroutine path, and assume that the lock is already taken in the
coroutine path.

The only thing we need to do for the wrapped function is adding the
GRAPH_RDLOCK annotation. Doing so also allows us to mark the
corresponding callbacks in BlockDriver as GRAPH_RDLOCK_PTR.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20221207131838.239125-19-kwolf@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>

block.c

diff --git a/block.c b/block.c
index 1a82fd1..9c2ac75 100644
--- a/block.c
+++ b/block.c
@@ -5402,6 +5402,7 @@
                                BdrvCheckResult *res, BdrvCheckMode fix)
 {
     IO_CODE();
+    assert_bdrv_graph_readable();
     if (bs->drv == NULL) {
         return -ENOMEDIUM;
     }
@@ -6617,6 +6618,7 @@
     IO_CODE();
 
     assert(!(bs->open_flags & BDRV_O_INACTIVE));
+    assert_bdrv_graph_readable();
 
     if (bs->drv->bdrv_co_invalidate_cache) {
         bs->drv->bdrv_co_invalidate_cache(bs, &local_err);