Google Git
Sign in
qemu / qemu / 5aaed9caf150390bd702a7da86a287a579b20d73
commit5aaed9caf150390bd702a7da86a287a579b20d73[log] [tgz]
authorVladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>Thu Feb 16 21:03:49 2023 +0300
committerMichael S. Tsirkin <mst@redhat.com>Thu Mar 02 03:10:49 2023 -0500
tree72242bbca3058cd8fe7ff3ef36fbe88ecd7ef709
parentf90d932094c03cb2ebb856a6da4ad0a5b05d9c27 [diff]
pcie: introduce pcie_sltctl_powered_off() helper

In pcie_cap_slot_write_config() we check for PCI_EXP_SLTCTL_PWR_OFF in
a bad form. We should distinguish PCI_EXP_SLTCTL_PWR which is a "mask"
and PCI_EXP_SLTCTL_PWR_OFF which is value for that mask.

Better code is in pcie_cap_slot_unplug_request_cb() and in
pcie_cap_update_power(). Let's use same pattern everywhere. To simplify
things add also a helper.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Anton Kuchin <antonkuchin@yandex-team.ru>
Message-Id: <20230216180356.156832-12-vsementsov@yandex-team.ru>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
1 file changed
tree: 72242bbca3058cd8fe7ff3ef36fbe88ecd7ef709
  1. .github/
  2. .gitlab/
  3. .gitlab-ci.d/
  4. accel/
  5. audio/
  6. authz/
  7. backends/
  8. block/
  9. bsd-user/
  10. chardev/
  11. common-user/
  12. configs/
  13. contrib/
  14. crypto/
  15. disas/
  16. docs/
  17. dump/
  18. ebpf/
  19. fpu/
  20. fsdev/
  21. gdb-xml/
  22. gdbstub/
  23. hw/
  24. include/
  25. io/
  26. libdecnumber/
  27. linux-headers/
  28. linux-user/
  29. migration/
  30. monitor/
  31. nbd/
  32. net/
  33. pc-bios/
  34. plugins/
  35. po/
  36. python/
  37. qapi/
  38. qga/
  39. qobject/
  40. qom/
  41. replay/
  42. roms/
  43. scripts/
  44. scsi/
  45. semihosting/
  46. softmmu/
  47. stats/
  48. storage-daemon/
  49. stubs/
  50. subprojects/
  51. target/
  52. tcg/
  53. tests/
  54. tools/
  55. trace/
  56. ui/
  57. util/
  58. dtc
  59. meson
  60. .cirrus.yml
  61. .dir-locals.el
  62. .editorconfig
  63. .exrc
  64. .gdbinit
  65. .gitattributes
  66. .gitignore
  67. .gitlab-ci.yml
  68. .gitmodules
  69. .gitpublish
  70. .mailmap
  71. .patchew.yml
  72. .readthedocs.yml
  73. .travis.yml
  74. block.c
  75. blockdev-nbd.c
  76. blockdev.c
  77. blockjob.c
  78. configure
  79. COPYING
  80. COPYING.LIB
  81. cpu.c
  82. cpus-common.c
  83. disas.c
  84. event-loop-base.c
  85. gitdm.config
  86. hmp-commands-info.hx
  87. hmp-commands.hx
  88. iothread.c
  89. job-qmp.c
  90. job.c
  91. Kconfig
  92. Kconfig.host
  93. LICENSE
  94. MAINTAINERS
  95. Makefile
  96. memory_ldst.c.inc
  97. meson.build
  98. meson_options.txt
  99. module-common.c
  100. os-posix.c
  101. os-win32.c
  102. page-vary-common.c
  103. page-vary.c
  104. qemu-bridge-helper.c
  105. qemu-edid.c
  106. qemu-img-cmds.hx
  107. qemu-img.c
  108. qemu-io-cmds.c
  109. qemu-io.c
  110. qemu-keymap.c
  111. qemu-nbd.c
  112. qemu-options.hx
  113. qemu.nsi
  114. qemu.sasl
  115. README.rst
  116. replication.c
  117. trace-events
  118. VERSION
  119. version.rc