tree 377e0e64385e96725f0af15e44614744392c4117
parent be16b8bf9f231d19c172961d3327f9f72a7cd45f
author Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> 1630955209 +0300
committer Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> 1640094730 +0100

nbd/client-connection: nbd_co_establish_connection(): return real error

The only caller of nbd_do_establish_connection() that uses errp is
nbd_open(). The only way to cancel this call is through open_timer
timeout. And for this case, user will be more interested in description
of last failed connect rather than in
"Connection attempt cancelled by other operation".

So, let's change behavior on cancel to return previous failure error if
available.

Do the same for non-blocking failure case. In this case we still don't
have a caller that is interested in errp. But let's be consistent.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>